rm-hull / dot-block / 19119954583

43%

push

github

fix: Allow lookup when eTLD+1 derivation fails

This corrects an issue where `publicsuffix.EffectiveTLDPlusOne`
would return an error for certain apex domains (e.g.,
`s3.amazonaws.com.`), leading to false error returns.

The logic now ignores errors indicating that the domain is
effectively the apex domain itself.

This commit also includes refactoring of Prometheus metric
registration:

*   Moves `shouldRegister` helper into a new file.
*   Uses `shouldRegister` instead of `MustRegister` to prevent
    panics during testing due to re-registration.
*   Localizes `blockList` initialization in tests to improve
    isolation.

11 of 13 new or added lines in 2 files covered. (84.62%)

304 of 537 relevant lines covered (56.61%)

0.62 hits per line