rm-hull / dot-block / 19115631756

51%

main: 43%

Build Type

Pull #3

github

Committed by rm-hull

Commit Message

test: Refactor DNS tests using local mock server helpers

This commit significantly refactors the DNS dispatcher unit tests to use
dedicated, isolated local mock DNS servers managed by new helper
functions (`startLocalDNS`, `dnsRecord`, and `waitForPort`).

This eliminates complex, manually synchronized inline server setup logic
within individual tests, greatly improving test reliability and
maintainability.

Minor cleanup changes were also applied to `internal/dns.go`:
* Corrects the order of setting the response Rcode and reporting the
  error during upstream failures.
* Removes redundant error logging in `resolveUpstream`.

Pull Request Pull Request #3: refactor: Refactor DNS handling for granular cache

Run Details

103 of 115 new or added lines in 1 file covered. (89.57%)

2 existing lines in 1 file now uncovered.

226 of 445 relevant lines covered (50.79%)

0.55 hits per line