bitcoindevkit / bdk_wallet / 19108806954

85%

master: 85%

push

github

Merge bitcoindevkit/bdk_wallet#336: Add `apply_block_events` and `apply_block_connected_to_events`

<a class=hub.com/bitcoindevkit/bdk_wallet/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk_wallet/commit/e9a303436b8d22d6a73552316e74da021b67977c">e9a303436<a href="https://github.com/bitcoindevkit/bdk_wallet/commit/abc9cd8531a2a2892626b4698c507cbd26daa01b"> test(wallet): add tests for apply_block_events (Steve Myers)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk_wallet/commit/3f0664e9485f531f6ba98e4a3a8bf75e69b0a3e5">3f0664e94</a><a href="https://github.com/bitcoindevkit/bdk_wallet/commit/abc9cd8531a2a2892626b4698c507cbd26daa01b"> f Duplicate event logic rather than business logic (Elias Rohrer)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk_wallet/commit/df444d06bda972819541d75f120cf8556a6a61e9">df444d06b</a> Add `apply_block_events` and `apply_block_connected_to_events` (Elias Rohrer)

Pull request description:

  ### Description

  Previously, we added a new `Wallet::apply_update_events` method that returned `WalletEvent`s. Unfortunately, no corresponding APIs were added for the `apply_block` counterparts. Here we fix this omission.

  ### Notes to the reviewers

  I opened this towards the `release-2.2` branch, but it would probably need another release branch. Or let me know if you prefer to open it against master (which seems to be lacking `apply_update_events` currently though).

  I also added no test coverage given that none seems to exist for `Wallet::apply_block` in the first place. Let me know if I should add something here.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `just p` before pushing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [x] I've added docs for the new feature

  cc @notmandatory

ACKs for top commit:
  ValuedMammal:
    ACK e9a303436b8d22d6a73552316e74da021b67977c
  notmandatory:
    (self) ACK e9a303436b8d22d6a73552316e74da021b67977c

Tree-SHA512: f62771ee864ec342ebfbd1966e56dc76e3c

34 of 69 new or added lines in 1 file covered. (49.28%)

7059 of 8297 relevant lines covered (85.08%)

3260.98 hits per line