• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

tahoe-lafs / tahoe-lafs / 1348
95%

Build:
DEFAULT BRANCH: master
Ran 26 Aug 2016 10:04PM UTC
Jobs 2
Files 141
Run time 27min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
1348

push

travis-ci

warner
make IServer.get_serverid() use pubkey, not tubid

This is a change I've wanted to make for many years, because when we get
to HTTP-based servers, we won't have tubids for them. What held me back
was that there's code all over the place that uses the serverid for
various purposes, so I wasn't sure it was safe. I did a big push a few
years ago to use IServer instances instead of serverids in most
places (in #1363), and to split out the values that actually depend upon
tubid into separate accessors (like get_lease_seed and
get_foolscap_write_enabler_seed), which I think took care of all the
important uses.

There are a number of places that use get_serverid() as dictionary key
to track shares (Checker results, mutable servermap). I believe these
are happy to use pubkeys instead of tubids: the only thing they do with
get_serverid() is to compare it to other values obtained from
get_serverid(). A few places in the WUI used serverid to compute display
values: these were fixed.

The main trouble was the Helper: it returns a HelperUploadResults (a
Copyable) with a share->server mapping that's keyed by whatever the
Helper's get_serverid() returns. If the uploader and the helper are on
different sides of this change, the Helper could return values that the
uploader won't recognize. This is cosmetic: that mapping is only used to
display the upload results on the "Recent and Active Operations" page.
I've added code to StorageFarmBroker.get_stub_server() to fall back to
tubids when looking up a server, so this should still work correctly
when the uploader is new and the Helper is old. If the Helper is new and
the uploader is old, the upload results will show unusual server ids.

refs ticket:1363

11 of 11 new or added lines in 3 files covered. (100.0%)

24228 of 26301 relevant lines covered (92.12%)

0.92 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
4
100.0
src/allmydata/storage_client.py

Uncovered Existing Lines

Lines Coverage ∆ File
1
100.0
src/allmydata/storage_client.py
5
100.0
src/allmydata/web/status.py
Jobs
ID Job ID Ran Files Coverage
1 1348.1 26 Aug 2016 10:04PM UTC 0
92.12
Travis Job 1348.1
2 1348.2 26 Aug 2016 10:31PM UTC 0
Travis Job 1348.2
Source Files on build 1348
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #1348
  • 54f974d4 on github
  • Prev Build on master (#1346)
  • Next Build on master (#1349)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc