aarongarrett / quorum / 19083081503

91%

Build Type

push

github

Committed by aarongarrett

Commit Message

Improve security, observability, and error handling

  Security improvements:
  - Prevent information disclosure by returning generic error messages to clients while logging detailed errors server-side
  - Require SECRET_KEY and ADMIN_PASSWORD environment variables in Docker Compose
  - Add production build validation for frontend API configuration
  - Fix broad exception handling to catch only specific exception types

  Observability enhancements:
  - Add comprehensive health check metrics including database pool status and memory usage
  - Store request ID in request.state for access in endpoint handlers
  - Enhance SSE error logging with endpoint name and path context

  Error handling improvements:
  - Improve duplicate vote detection with specific IntegrityError constraint checking
  - Replace broad exception catches with targeted exception handling in JWT validation

  Configuration fixes:
  - Fix stdout blocking issue by replacing print() with logger.warning() in config validation
  - Move production config validation to main.py after logging setup to prevent initialization issues

  Testing:
  - Add unit tests for request ID tracking middleware
  - Add unit tests for vote service IntegrityError handling
  - Add integration tests for error message security
  - Add integration tests for enhanced health check metrics
  - Add integration tests for SSE error logging context

Coverage Stats

130 of 159 branches covered (81.76%)

Branch coverage included in aggregate %.

1 of 2 new or added lines in 1 file covered. (50.0%)

39 existing lines in 6 files now uncovered.

1215 of 1322 relevant lines covered (91.91%)

5.65 hits per line