stacklok / toolhive / 19077774703

51%

Build Type

push

github

Committed by web-flow

Commit Message

Fix vmcp capability name mapping when forwarding to backends (#2457)

When conflict resolution strategies rename capabilities (tools, resources,
prompts), vmcp was forwarding the resolved/prefixed name to backends
instead of the original name that backends expect. This caused all tools
renamed by conflict resolution to fail with "unknown tool" errors.

For example, with prefix strategy:
- Client calls: fetch_fetch
- vmcp was sending to backend: fetch_fetch (❌ backend doesn't know this)
- vmcp should send to backend: fetch (✅ original name)

Changes:
1. Added OriginalCapabilityName field to BackendTarget to preserve the
   mapping between resolved names and original backend names
2. Updated routing table construction to store original names for all
   capabilities (tools, resources, prompts)
3. Added GetBackendCapabilityName() method to BackendTarget to
   encapsulate the name translation logic cleanly
4. Updated tool/resource/prompt handlers to use original names when
   forwarding requests to backends

This fix works for all conflict resolution strategies:
- Prefix: fetch → fetch_fetch (OriginalCapabilityName="fetch")
- Priority: tool_name → tool_name (OriginalCapabilityName="tool_name")
- Manual: fetch → custom_name (OriginalCapabilityName="fetch")

Added comprehensive tests for GetBackendCapabilityName() covering all
strategies and capability types.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude <noreply@anthropic.com>

Run Details

17 of 35 new or added lines in 3 files covered. (48.57%)

17 existing lines in 2 files now uncovered.

21778 of 45167 relevant lines covered (48.22%)

37.46 hits per line