bramp / build-along / 19055382140

89%

Build Type

push

github

Committed by bramp

Commit Message

Refactor classifiers to two-phase candidate pattern

This is a major architectural refactoring that separates element evaluation
from classification into two distinct phases:

Phase 1 - evaluate(): Score elements and construct LegoPageElement objects
Phase 2 - classify(): Select winners from pre-built candidates

Key changes:
- Renamed calculate_scores() to evaluate() across all classifiers
- Moved candidate construction from classify() into evaluate()
- Removed deprecated 'scores' parameter from all classifier methods
- Introduced Candidate dataclass to store scoring + construction results
- Updated PartsImageClassifier to use instance variables instead of scores dict
- Removed unused imports (Any, ScoreKey)

Benefits:
- Single parse: Elements constructed once in evaluate(), not re-parsed
- Full decision trail: Candidates preserve scores, failures, and reasons
- Re-evaluation ready: All candidates available for hint-based adjustments
- Cleaner separation: Scoring logic separate from winner selection

Updated classifiers:
- PageNumberClassifier
- StepNumberClassifier
- PartCountClassifier
- PartsListClassifier
- PartsImageClassifier

All tests pass. Documentation updated to reflect new architecture.

Run Details

113 of 129 new or added lines in 7 files covered. (87.6%)

6 existing lines in 3 files now uncovered.

3367 of 3821 relevant lines covered (88.12%)

0.88 hits per line