bramp / build-along / 19051820527

89%

Build Type

push

github

Committed by bramp

Commit Message

refactor: Complete migration to candidates-based ClassificationResult

This commit completes a major refactoring to eliminate data duplication
in the ClassificationResult class and improve code organization.

Core Changes to ClassificationResult (types.py):
- Removed redundant _labeled_elements and _scores fields
- Made candidates the single source of truth for all classification data
- Updated all accessor methods to derive from candidates dictionary

Classifier Updates:
- PageNumberClassifier: Include ALL scored elements in candidates,
  use is_winner flag, construct PageNumber objects
- PartCountClassifier: Construct PartCount objects
- StepNumberClassifier: Construct StepNumber objects
- PartsListClassifier: Populate candidates (construction in builder)

Code Extraction & Organization:
- Created text_extractors.py: Centralized parsing logic for page numbers,
  step numbers, and part counts
- Created hierarchy_builder.py: Extracted hierarchy-building logic from
  lego_page_builder.py

Test Updates:
- Migrated lego_page_builder_test.py to candidates API
- Fixed test expectations for part count parsing
- Added tests for new modules

All 100+ tests passing.

Run Details

594 of 649 new or added lines in 14 files covered. (91.53%)

7 existing lines in 3 files now uncovered.

3402 of 3901 relevant lines covered (87.21%)

0.87 hits per line