simonsobs / socs / 19041965849

38%

Build Type

push

github

Committed by web-flow

Commit Message

Fix recursion error in moxa_serial module (#935)

* update moxa_serial.py to use specific exceptions (TimeoutError and BlockingIOError) in reading data

* update

* update moxa_serial.py

* Update moxa_serial.py

In `readbuf()`, use a byte type string for `msg` and `msg_current`.

* Add general exception handling

Since we were catching BaseException before, there's some chance we were
catching something that isn't a TimeoutError or BlockingIOError. This catches
anything else and logs it, just in case.

---------

Co-authored-by: Shunsuke Adachi <38268229+sadachi5@users.noreply.github.com>

Run Details

1 of 34 new or added lines in 1 file covered. (2.94%)

2 existing lines in 1 file now uncovered.

7333 of 19332 relevant lines covered (37.93%)

0.38 hits per line