dcdpr / jp / 19033105445

58%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(config, llm)!: Rename `RunMode::Always` to `Unattended` (#308)

The tool calling configuration used confusing terminology and overly
complex control flow. `RunMode::Always` and `ResultMode::Always` didn't
clearly convey that tools run without user interaction, while the
`Never` variants added complexity without clear benefit over `enabled =
false`.

This change renames `Always` to `Unattended` across both `RunMode` and
`ResultMode` enums, making the intent explicit: tools run without
attended user interaction. The `Never` variants are removed entirely -
for `RunMode`, the rejection-with-reasoning functionality is integrated
directly into the `Ask` prompt as option 'r', eliminating the need for a
separate mode.

The control flow in `prepare_run` and `prepare_result` is significantly
simplified by replacing loop-based state machines with direct recursion
using `Box::pin()`. This eliminates `continue` statements and makes the
code paths more straightforward to follow.

All configuration files are updated to use the new `unattended` value,
replacing the previous `always` setting throughout personas and tool
configurations.

BREAKING CHANGE: Configuration values changed

The `run` and `result` configuration fields no longer accept `always` or
`never` values. Replace `always` with `unattended` in all tool
configurations. The `never` mode is removed - use the runtime prompt
options instead to skip tool execution when needed, or disable the tool
completely with `enabled = false`.

Related: #199

Signed-off-by: Jean Mertz <git@jeanmertz.com>

Run Details

0 of 115 new or added lines in 1 file covered. (0.0%)

2 existing lines in 1 file now uncovered.

7699 of 16014 relevant lines covered (48.08%)

14.49 hits per line