aarongarrett / quorum / 19024107898

91%

push

github

  Fix critical cache issues and add comprehensive testing

  Address critical issues from CODEBASE_ISSUES.md and add extensive test coverage:

  ## Critical Fixes (Issues #1, #2)
  - Fix cache race condition using double-check locking with RLock
  - Add LRU eviction with max_size limit (100) to prevent unbounded growth
  - Switch from threading.Lock to RLock to prevent deadlock

  ## Observability Improvements (Issues #8, #13, #15)
  - Add cache hit/miss tracking and statistics
  - Create admin cache stats endpoint (GET /api/v1/admin/cache/stats)
  - Enhance /health endpoint with cache metrics and DB connection check
  - Add logging for all cache invalidation operations

  ## Configuration & Error Handling (Issues #9, #14)
  - Make SSE intervals configurable via environment variables
  - Improve SSE error handling to distinguish DB errors from unexpected errors
  - Fix SSE endpoint bug: handle AttributeError/TypeError for malformed tokens

  ## Testing
  - Add 27 unit tests for cache (TTLCache, get_or_fetch)
  - Add 13 unit tests for SSE event_generator
  - Add 20 integration tests for SSE endpoints
  - Add integration tests for cache stats and health endpoints

  ## Bug Fixes
  - Fix /health endpoint route ordering to prevent React catch-all interception

127 of 155 branches covered (81.94%)

Branch coverage included in aggregate %.

1154 of 1282 relevant lines covered (90.02%)

5.11 hits per line