zhmcclient / python-zhmcclient / test-4093

80%

push

github

Reduced number of HMC sessions in end2end tests (#2016)

The key change is to change the scope of the pytest fixtures in
zhmcclient.testutils from 'module' to 'session'. That causes the
hmc_session fixture (and thus the HMC session) to be created only
once during a pytest run.

All the other changes are follow-up requirements for that to work.

Details:

* Changed the scope of the pytest fixtures in the zhmcclient.testutils subtree
  from "module" to "session".

* The "session" scope of fixtures is only honored by pytest if the fixtures are
  globally known to pytest. Therefore, the definition of the fixtures has been
  changed as follows:

    - Fixtures available for zhmcclient users are now registered as a pytest
      plugin. This has been done for the entire zhmcclient.testutils
      subtree, because most of the non-fixture functionality in that subtree
      is used by the fixtures. All the public elements are still in place in
      the zhmcclient.testutils module and can be imported from there, so
      there is no change for users.

    - All other fixtures were moved into conftest.py files (which are
      special files recognized by pytest). These fixtures are available to
      the development environment of zhmcclient, but not to its users:

      - tests/unit/conftest.py: The http_mocked_*() fixtures that were
        previously in tests/common/http_mocked_fixtures.py. The zhmc_capture()
        fixture that was previously in tests/unit/zhmcclient/test_logging.py,
        and was named capture(), which seemed a bit too general. Since this
        is an internal fixture, the rename is no change for users.

      - tests/end2end/conftest.py: The zhmc_logger() fixture that was
        previously in tests/end2end/utils.py and was named logger(), which
        seemed a bit too general. Since this is an internal fixture, the
        rename is no change for users.

* In addition, the "session" scope of fixtures is only honored by pytest if the... (continued)

3 of 3 new or added lines in 1 file covered. (100.0%)

9247 of 11598 relevant lines covered (79.73%)

9.52 hits per line