stacklok / toolhive / 18970043441

51%

Build Type

push

github

Committed by web-flow

Commit Message

vMCP: Implement CLI serve command and session management (#2406)

* Implement CLI serve command and session management for Virtual MCP Server

This completes the MCP protocol server implementation by adding CLI
integration, session management, and health endpoints. The Virtual MCP
Server can now aggregate multiple backend MCP servers from a ToolHive
group and serve them through a unified MCP endpoint.

Changes:
- Implement 'vmcp serve' command with full component wiring
- Integrate MCP session management using ToolHive's session.Manager
- Add /health and /ping endpoints with minimal security-conscious responses
- Create session adapter exposing session.Manager via SDK interface
- Add comprehensive test coverage for session lifecycle and health endpoints
- Provide example configuration file with documentation

Session Management Architecture:
Sessions are ENTIRELY managed by ToolHive's session.Manager (the same
component used in pkg/transport/proxy/streamable for MCP sessions).
The mark3labs SDK does NOT manage sessions - it only calls our
sessionIDAdapter interface during MCP protocol flows:
  - Generate(): Called on MCP initialize to create session IDs
  - Validate(): Called on every request to check session validity
  - Terminate(): Called on HTTP DELETE to end sessions

All session storage, TTL-based cleanup, and lifecycle management is
handled by ToolHive infrastructure. The adapter is purely glue code
following DDD principles (infrastructure in server bounded context).

Security:
- Health endpoint intentionally minimal to prevent information disclosure
- No version, session counts, or capability metrics exposed
- Cryptographically secure session IDs per MCP specification
- Session termination properly handled with 404 semantics

Testing:
- Added 381 lines of test coverage for new functionality
- Session adapter: 9 test cases covering full lifecycle
- Health endpoints: 3 test cases including security validation

The Virtual MCP Server is now funct... (continued)

Run Details

148 of 262 new or added lines in 3 files covered. (56.49%)

1 existing line in 1 file now uncovered.

20785 of 43802 relevant lines covered (47.45%)

22.14 hits per line