ProjectOpenSea / opensea-js / 18957242970

88%

master: 30%

push

github

fix: use OpenSea API fulfillment transaction data directly (#1803)

* fix: use OpenSea API fulfillment transaction data directly

Fixes #1795

Changes:
- Modified fulfillOrder to use transaction data from OpenSea API's
  generateFulfillmentData endpoint instead of using seaport-js
- This ensures that collection offers are fulfilled correctly with
  proper criterias automatically generated by the API
- Deprecated recipientAddress, unitsToFill, and domain parameters
  as these are now determined by the API transaction data
- Updated tests to reflect the new implementation

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Remove deprecated parameters from fulfillOrder

- Removed recipientAddress, unitsToFill, and domain parameters
- These are now determined by the OpenSea API transaction data
- Updated public SDK method and internal FulfillmentManager
- Removed tests for deprecated parameters
- Updated documentation

* Omit domain parameter when calling fulfillPrivateOrder

* Use ethers Interface to encode transaction from API data

- Encode transaction calldata using ethers.Interface with function signature
- Pass structured input_data values from API to encoded function
- Updated type definitions to support new API response structure
- Updated test mocks with proper function signatures and input data

* Remove redundant signer check

- Use existing context.requireAccountIsAvailable check
- Simplify code by directly using context.signerOrProvider as Signer

* Fix parameter ordering for ethers encoding

- Order parameters correctly based on function name
- Handle fulfillAdvancedOrder, fulfillBasicOrder, and fulfillOrder
- Provide default values for optional parameters like fulfillerConduitKey

* Revert input_data type changes, use type assertion instead

- Keep original input_data type with orders field only
- Use 'as any' type assertion to access dynamic fields
- Maintains backward compati... (continued)

427 of 638 branches covered (66.93%)

Branch coverage included in aggregate %.

43 of 52 new or added lines in 3 files covered. (82.69%)

3932 of 4376 relevant lines covered (89.85%)

4.18 hits per line