Twingate / kubernetes-operator / 18957234874

97%

Build Type

push

github

Committed by web-flow

Commit Message

fix: Fix the reconciliation logic for Kubernetes resource (#822)

## Changes

- Fix the reconciliation for Kubernetes resource
+ Add port `443` explicitly to Gateway address in `TwingateResource`
CRD.
- Gateway address includes the port number in the backend so the CRD
should also include the port number toto avoid difference between CRD
data and what is returned in public API. Right now the CRD stores
`gateway.svc.default.local.cluster.local` while the API returns
`gateway.svc.default.local.cluster.local:443`, which results in
unnecessary update mutations.
+ When comparing the certificates, convert them to
[`cryptography.x509.Certificate`](https://cryptography.io/en/latest/x509/reference/#cryptography.x509.Certificate)
- Right now we compare certificates in PEM format but the same
certificate can be formatted differently in PEM.

- Add integration test to make sure we don't make unnecessary update
mutation for Kubernetes resources

---------

Co-authored-by: Eran Kampf <eran@ekampf.com>

Run Details

199 of 224 branches covered (88.84%)

Branch coverage included in aggregate %.

23 of 23 new or added lines in 5 files covered. (100.0%)

1 existing line in 1 file now uncovered.

1235 of 1261 relevant lines covered (97.94%)

0.98 hits per line