Tribally-Games / arcade-contracts / 18929517494

98%

push

github

refactor: use custom error reverts for quote calculations

Replace return values with CalculatedAmountOut custom error for quote
operations across adapters and gateway. This improves gas efficiency for
view-only quote simulations by using reverts instead of state-changing
returns.

- Add CalculatedAmountOut error to IDexSwapAdapter interface and LibErrors
- Update DummyDexAdapter and UniversalSwapAdapter getQuote implementations
- Update GatewayFacet calculateUsdc to use custom error
- Add parseCalculatedAmountOut utility in gateway-utils for error parsing
- Update test scripts to handle new quote mechanism
- Improve deployment script verification flow with skip option
- Update deployment addresses for Base and Ronin networks
- Add warning note about non-USDC deposits on Base

54 of 63 branches covered (85.71%)

Branch coverage included in aggregate %.

13 of 17 new or added lines in 4 files covered. (76.47%)

237 of 241 relevant lines covered (98.34%)

18.67 hits per line