stacklok / toolhive / 18912579892

51%

Build Type

push

github

Committed by web-flow

Commit Message

Fix server port when network mode is `host` (#2353)

Docker networking works differently depending on whether it's running
inside a VM or on the (linux) host itself, with VM-based installations
like Docker Desktop not supporting `host` network. What happens is
that the port is exposed on the VM rather than the actual host. Note
that this is the case for linux running Docker Desktop.

On the other hand, Docker Engine installations work just fine on
linux, but we were still configuring the Proxy to try to connect to
the wrong port.

This is PR assumes that
* all linux installations run docker engine
* all non-linux installations run on VMs

Fixes #2317

Run Details

10 of 22 new or added lines in 3 files covered. (45.45%)

2 existing lines in 1 file now uncovered.

19289 of 41005 relevant lines covered (47.04%)

15.15 hits per line