goto / guardian / 18875764968
66%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 112
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 67.964% (-1.0%) from 68.985%
18875764968

push

github

web-flow 
feat: implement summary and advanced filtering for grant and approval APIs (#231)

* feat: implement poc summaries for guardian

* Update grant_repository.go

* Update grant_repository.go

* Update grant_repository.go

* dev

* dev

* dev

* dev

* dev

* dev

* Add unique summary support to grant listing

Introduces support for unique field summaries in grant listing APIs. Updates protobuf definitions, handlers, domain models, and repositories to handle 'summary_uniques' and return unique counts and values in summary results.

* Quote column names in generateUniqueSummaries query

Updated the query in generateUniqueSummaries to quote table and column names, ensuring correct SQL syntax and preventing issues with reserved words or special characters.

* Initialize Uniques slice in ToSummaryProto

Added initialization of the Uniques slice in the ToSummaryProto method to ensure the SummaryResult proto includes the correct number of unique entries.

* Refactor Distinct query in generateUniqueSummaries

Simplifies the GORM query by removing the redundant Table call and using Distinct directly on the column. This streamlines the code and maintains the same functionality.

* Add baseTableName param to generateUniqueSummaries

Refactored generateUniqueSummaries to accept a baseTableName parameter and updated its usage in GrantRepository. This change improves flexibility and correctness when querying distinct values from specific tables.

* Improve summary error handling and input validation

Refactored summary generation for grants and approvals to provide more granular error messages for invalid input formats, empty table/column names, and unsupported tables. Enhanced input validation and standardized slice handling for summary fields. Updated repository methods to use generator functions for DB queries, and improved join logic for summary queries.

* Fix function name for approval summary joins

Renamed applyApprovalsSummariesJoins to applyApprovalsSummaryJ... (continued)

222 of 615 new or added lines in 14 files covered. (36.1%)

9 existing lines in 7 files now uncovered.

11490 of 16906 relevant lines covered (67.96%)

4.57 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
3
51.06
 -3.48% core/approval/service.go
8
33.33
 -16.67% domain/approval.go
8
16.79
 -1.18% domain/grant.go
12
72.16
 -0.14% api/handler/v1beta1/approval.go
23
70.8
 -1.11% api/handler/v1beta1/adapter.go
31
76.51
 -4.3% core/grant/service.go
46
54.68
 -2.35% api/handler/v1beta1/grant.go
55
57.77
 5.46% internal/store/postgres/approval_repository.go
65
58.45
 -10.48% internal/store/postgres/grant_repository.go
142
22.34
 -68.96% internal/store/postgres/utils.go

Uncovered Existing Lines

Lines Coverage ∆ File
1
70.8
 -1.11% api/handler/v1beta1/adapter.go
1
72.16
 -0.14% api/handler/v1beta1/approval.go
1
76.51
 -4.3% core/grant/service.go
1
33.33
 -16.67% domain/approval.go
1
16.79
 -1.18% domain/grant.go
2
54.68
 -2.35% api/handler/v1beta1/grant.go
2
57.77
 5.46% internal/store/postgres/approval_repository.go
Jobs
ID Job ID Ran Files Coverage
1 18875764968.1 112
67.96
 GitHub Action Run
Source Files on build 18875764968