agentjido / req_llm / 43fe00465dfe43556cdb9faf93b49ef0bdd94340-PR-145

53%

main: 49%

Build Type

Pull #145

github

Committed by neilberkman

Commit Message

Fix Bedrock Anthropic thinking removal for forced tool_choice

Bedrock's object generation and explicit tool_choice force tool use, which is
incompatible with extended thinking. The thinking parameter must be removed
from additional_model_request_fields in these cases.

The fix adds `maybe_clean_thinking_after_translation` which runs after
Options.process in the attach method. It cannot be done in translate_options
because Options.process restores the original provider_options, discarding
any modifications to nested fields like additional_model_request_fields.

Also fixes `determine_use_converse` to check provider_options for
use_converse and anthropic_prompt_cache, since these are nested after
Options.process.

This enables object generation with reasoning_effort for Bedrock Claude
models.

Pull Request Pull Request #145: Fix Bedrock streaming, extended thinking, and fixture encoding

Run Details

22 of 27 new or added lines in 2 files covered. (81.48%)

2 existing lines in 2 files now uncovered.

3675 of 6975 relevant lines covered (52.69%)

433.54 hits per line