pulibrary / orangelight / 1ef089f4-3bd1-444b-9e7a-4b53d6118a5a

95%

push

circleci

Improve performance of in_a_special_collection? method (#5270)

* Use memoized holdings_1display, rather than reparsing it
* Memoize Bibdata.holding_locations, since it can be slow to read
  and parse it from the cache

Before:

```
$ bundle exec ruby benchmarks/app/models/solr_document.rb
ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +YJIT +PRISM [arm64-darwin24]
Warming up --------------------------------------
                        14.000 i/100ms
Calculating -------------------------------------
                        140.216 (± 3.6%) i/s    (7.13 ms/i) -    714.000 in   5.097520s
```

After:

```
ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +YJIT +PRISM [arm64-darwin24]
Warming up --------------------------------------
                        82.533k i/100ms
Calculating -------------------------------------
                        823.700k (± 0.9%) i/s    (1.21 μs/i) -      4.127M in   5.010307s
```

6 of 6 new or added lines in 1 file covered. (100.0%)

6142 of 6441 relevant lines covered (95.36%)

1491.14 hits per line