ng-select / ng-select / 18857330073

92%

push

github

fix: fix scroll behavior for ng-select used in shadow dom (#2712)

* fix: (Accessibility) Signal is not being called in the template

- Cleaned up and standardized the HTML formatting for better readability.
- Adjusted indentation and spacing for consistency across the component.
- Ensured that conditional templates and bindings are clearly structured.

This refactor enhances maintainability and aligns with best practices for code formatting.

* fix: fix scroll behavior for ng-select used in shadow dom

- Removed duplicate imports and organized the import statements for clarity.
- Simplified the scroll event subscription logic to directly use the scrollTop property, enhancing readability and performance.

This refactor contributes to better maintainability and aligns with best practices for code structure.

* refactor: improve HTML structure and formatting in ng-select component

- Enhanced readability by standardizing indentation and spacing throughout the template.
- Cleaned up conditional templates and bindings for better clarity.
- Ensured consistent formatting for improved maintainability.

This refactor aligns with best practices for code structure and enhances the overall quality of the component.

* fix: enhance scroll event handling in NgDropdownPanelComponent

- Updated the scroll event subscription to directly access the scrollTop property from the event target, improving clarity and performance.
- This change enhances the maintainability of the code by ensuring a more straightforward approach to handling scroll events.

Aligns with best practices for code structure and readability.

* fix: improve scroll event handling in NgDropdownPanelComponent

- Enhanced the scroll event subscription to ensure the target element is valid and contains the scrollTop property before accessing it, improving robustness and preventing potential errors.
- This change contributes to better maintainability and aligns with best practices for handling DOM events.... (continued)

473 of 539 branches covered (87.76%)

Branch coverage included in aggregate %.

0 of 3 new or added lines in 1 file covered. (0.0%)

978 of 1040 relevant lines covered (94.04%)

177.39 hits per line