stacklok / toolhive / 18851856932

51%

Build Type

push

github

Committed by web-flow

Commit Message

Add Virtual MCP Server routing interfaces and domain model (#2333)

* Add Virtual MCP Server routing interfaces and domain model

Implement foundational domain interfaces for Virtual MCP Server (vMCP)
following Domain-Driven Design principles. This enables parallel
implementation of vMCP features across multiple teams.

Package structure:
- pkg/vmcp/types.go: Shared domain types (BackendTarget, Tool, etc.)
- pkg/vmcp/errors.go: Common domain errors
- pkg/vmcp/router/: Request routing interfaces
- pkg/vmcp/aggregator/: Capability aggregation interfaces
- pkg/vmcp/auth/: Authentication interfaces (incoming & outgoing)
- pkg/vmcp/composer/: Workflow engine interfaces
- pkg/vmcp/config/: Platform-agnostic configuration model
- pkg/vmcp/cache/: Token caching interfaces

Key design decisions:
- Shared types in root package avoid circular dependencies
- Extensible authentication via Strategy interface
- BackendDiscoverer abstraction enables CLI and K8s implementations
- RoutingTable maps capabilities to backends (composite tools excluded)
- Configuration model matches proposal YAML structure

Related: #2106

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Address PR feedback on vMCP routing interfaces

Changes:
- Use ConflictResolutionStrategy enum instead of string in ResolvedTool
- Remove specific auth strategy examples from OutgoingAuthenticator docs
  until design decisions are finalized

Addresses feedback from:
- yrobla: Use typed enum for conflict resolution strategy
- jhrozek: Defer auth strategy details until design is complete

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

Run Details

0 of 6 new or added lines in 1 file covered. (0.0%)

18 existing lines in 2 files now uncovered.

19075 of 40214 relevant lines covered (47.43%)

15.44 hits per line