spesmilo / electrum / 6591665294540800

61%

master: 63%

Build Type

Pull #10280

CirrusCI

Committed by f321x

Commit Message

qt: fix ServerWidget

The ServerWidget was not working properly, when switching from "Manual
Mode" to "Auto Connect" the change wouldn't get saved as it depended on
having a correct server string entered (which isn't neccessary for Auto
Connect).
Also makes the widget behave more sane by cleaning the server input if
Auto Connect is enabled and switching to Manual Mode if the user
manually selects a server.

Update the ServerWidget every time it is shown (on initialization and
also when the user opens it again or switches between network dialog
tabs).
This will clean it up if the user has entered some invalid server and
closes it, otherwise this server would stay in the input field until the
application is restarted.

The list of servers in the ServerWidget allows the user to right click
and 'Use as server' on the servers in the list, however internally it
was handled differently than what the user would expect when clicking on
'Use as server'. E.g. if the user selects a server in autoconnect mode
it would still stay in autoconnect mode so the server could switch again
to another server any time? Now it will also change the mode to manual
(or stay in single server mode if that was selected before), making it
clear that this server will stay selected.

If the user clicks on "Follow this branch" the connect mode will get changed to
autoconnect as internally we connect to a random interface on this
branch.

Pull Request Pull Request #10280: qt: fix ServerWidget (Network Tab)

Run Details

1 of 4 new or added lines in 1 file covered. (25.0%)

7 existing lines in 3 files now uncovered.

22884 of 37300 relevant lines covered (61.35%)

0.61 hits per line