bitcoindevkit / bdk_wallet / 18850737341

85%

Build Type

push

github

Committed by ValuedMammal

Commit Message

Merge bitcoindevkit/bdk_wallet#250: feat!: use `NetworkKind`

881df719c chore: rename `merge_network_kinds` to `intersect_network_kinds` (Luis Schwab)
fdb9d1355 fix: GeneratableKey options for PrivateKey, Xpriv (valued mammal)
b1d384fbb feat!(examples,test): use `NetworkKind` (Luis Schwab)
944274a72 feat!(wallet): use `NetworkKind` (Luis Schwab)
c22aa1390 feat!(keys): use `NetworkKind` (Luis Schwab)
ade83b4bc feat!(descriptor): use `NetworkKind` (Luis Schwab)

Pull request description:

  ### Description

  Closes #22.
  Closes #94.

  This PR replaces `bitcoin::Network` for `bitcoin::NetworkKind` where it applies.

  I also took the liberty of fixing up and adding  comments on the files I touched.

  ### Changelog
  - `wallet_name_from_descriptor()` takes `NetworkKind` instead of `Network`.
  - `DescriptorToExtract` takes `NetworkKind` instead of `Network`.
  - `impl IntoWalletDescriptor for <T>` takes `Network` instead `NetworkKind`.
  - `DescriptorTemplate::build()` takes `NetworkKind` instead of `Network`.
  - `ExtendedKey::into_xprv()` takes `NetworkKind` instead of `Network`.
  - `ExtendedKey::into_xpub()` takes `NetworkKind` instead of `Network`.
  - `DerivableKey::into_extended_key()` examples updated to use `NetworkKind` instead of `Network`.
  - `any_network()` renamed to `any_network_kind()`.
  - `mainnet_network()` renamed to `mainnet_network_kind()`.
  - `test_networks()` renamed to `test_network_kind()`.
  - `merge_networks()` renamed to `intersect_network_kinds()`.
  - `ValidNetworks` type alias renamed to `ValidNetworkKinds`.
  - `GeneratedKey::new()` takes `ValidNetworkKinds` instead of `ValidNetworks`.
  - `DescriptorKey::from_public()` takes `ValidNetworkKinds` instead of `ValidNetworks`.
  - `DescriptorKey::from_secret()` takes `ValidNetworkKinds` i... (continued)

Run Details

372 of 403 new or added lines in 9 files covered. (92.31%)

4 existing lines in 1 file now uncovered.

7001 of 8237 relevant lines covered (84.99%)

3632.02 hits per line