ThePalaceProject / web-patron / 18850433678

77%

push

github

PP-1631 : WCAG AA 2.1 compliance updates (#71)

## Description

<!--- Describe your changes -->
CPW now conforms to WCAG 2.1 AA standards, and in many cases, 2.1 AAA
standards.

Changes in detail:
- ghost variant button colors lacked contrast when button was focused
- certain headers were skipped, e.g. jumping from `<h1>` directly to
`<h3>`
- metadata like author on my books page required visually hidden terms
since aria-label should only be used with interactive elements
- opted for more semantically-appropriate description list tags for book
details metadata
- removed redundant or unnecessary aria-labels from non-interactive
elements
- added visually hidden text for screen readers where more context was
needed
- color contrast failed for "See More" button in "Recommendations"
section
- updated book card/cover link aria-labels to be less redundant when
being read by screen readers

re: redundant links: while WCAG recommends not providing duplicate links
adjacent to one another, it does not violate its standards. Possible
solutions include removing either the image or title as a link, hiding
one of the links from assistive technologies and keyboard navigation, or
providing identical aria labels since they go to identical resources. I
opted for two identical links because I think users would expect a book
cover to be a link to a resource (based on research done on retail
websites) and I think visually indicating the title as a link is
similarly important for sighted users. And WCAG standards recommend,
when possible, that it is better to make all interactive elements
available to all users.

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->
Certain public entities are required to conform to WCAG AA 2.1 standards
by April 2026. Changes made provide a better experience for users with
assistive technologies, namely screen readers and keyboard navigation.
<!--- If it fixes an open issue, please link to the issue ... (continued)

832 of 1086 branches covered (76.61%)

Branch coverage included in aggregate %.

15 of 15 new or added lines in 5 files covered. (100.0%)

1424 of 1611 relevant lines covered (88.39%)

28.82 hits per line