asticode / go-astits / 18836222963

78%

push

github

fix(packet_pool): align discontinuity detection with FFmpeg behavior (#70)

* Added devcontainer

* fix(packet_pool): align discontinuity detection with FFmpeg behavior

- Added check for PIDNull to skip discontinuity detection (matches FFmpeg's handling)
- Fixed adaptation field discontinuity indicator logic (matches FFmpeg's specification)
- Improved continuity counter validation to match FFmpeg's implementation
- Updated test case to reflect FFmpeg-compliant behavior

BREAKING CHANGE: The function now follows FFmpeg's rules for PIDNull and
adaptation field discontinuity indicators, which were previously handled differently.

Test case in packet_pool_test.go has been updated to match FFmpeg's expected behavior.

* chore(packet_pool_test): add test cases for PIDNull and empty packet list

Adds two new test cases to the hasDiscontinuity function:
- Verifies that a packet with PIDNull does not trigger a discontinuity
- Tests handling of empty packet lists when checking against a packet with continuity counter

* fix: correct trailing newline in Dockerfile and remove tmp/.gitignore due to rebase

---------

Co-authored-by: Quentin Renard <contact-github@asticode.com>

20 of 20 new or added lines in 1 file covered. (100.0%)

3161 of 4075 relevant lines covered (77.57%)

15.46 hits per line