pulibrary / orangelight / acce7e84-70ee-4ef0-a486-bfb9bdffe1e7

95%

main: 95%

Build Type

Pull #5268

circleci

Committed by sandbergja

Commit Message

Improve performance of online_holding_note?

* Rename method for clarity
* Symbolize names to reduce memory allocations
* Use any? with a block, rather than collect, so we
  don't need to iterate through every holding if we
  get a match before that
* Check in a microbenchmark
* Upgrade the json gem to a newer version that has
  some performance optimizations

Microbenchmark before:
```
$ bundle exec ruby benchmarks/app/controllers/concerns/orangelight/catalog.rb
ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +YJIT +PRISM [arm64-darwin24]
Warming up --------------------------------------
                        36.000 i/100ms
Calculating -------------------------------------
                        363.356 (± 1.4%) i/s    (2.75 ms/i) -      1.836k in   5.053892s
23428 objects allocated
```

Microbenchmark after:
```
ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +YJIT +PRISM [arm64-darwin24]
Warming up --------------------------------------
                        45.000 i/100ms
Calculating -------------------------------------
                        462.924 (± 1.5%) i/s    (2.16 ms/i) -      2.340k in   5.056152s
12617 objects allocated
```

* More iterations/second is good!
* Fewer allocations is good!

Pull Request Pull Request #5268: Improve performance of online_holding_note?

Run Details

7 of 7 new or added lines in 3 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

6140 of 6439 relevant lines covered (95.36%)

1502.13 hits per line