ben-manes / caffeine / #5091

100%

master: 100%

push

github

Allow users to read the maximum size without locking (fixes #1897)

Policy.Eviction#getMaximum() and weightedSize() now uses acquire
semantics to read the long fields.

Policy.Eviction#setMaximum() continues to lock because it must modify
recalculate the region sizes and adjust multiple fields. It writes to
the maximum's long field using release semantics.

Cache.cleanUp() and the internal cache calls performs its work under
the lock. It continues to read the long fields using plain semantics.
This is allowed since the monitor provides visibility since it is
written under the lock, so when it was a plain read/write we had the
lock provide the barriers. This is no different, we get to use a
stronger release store to allow for a non-lock read via acquire. Thus
there is no performance impact of the stronger memory visibility for
these important fields.

3810 of 3812 branches covered (99.95%)

4 of 6 new or added lines in 1 file covered. (66.67%)

7814 of 7816 relevant lines covered (99.97%)

1.0 hits per line