18822648545

Committed 26 Oct 2025 07:24PM UTC coverage: 79.831% (-0.4%) from 80.28%

Build # 18822648545

Build Type

Pull #22809

github

Committed by

web-flow

Commit Message

Merge 9401c4830 into 170094e99

Pull Request Pull Request #22809: golang: fix Go SDK version check for coverage experiment

Run Details

0 of 1 new or added line in 1 file covered. (0.0%)

439 existing lines in 25 files now uncovered.

77436 of 97000 relevant lines covered (79.83%)

3.35 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

95.24

/src/python/pants/backend/go/goals/check_test.py

# Copyright 2021 Pants project contributors (see CONTRIBUTORS.md).
# Licensed under the Apache License, Version 2.0 (see LICENSE).

from __future__ import annotations

from textwrap import dedent

import pytest

from pants.backend.go import target_type_rules
from pants.backend.go.goals import check
from pants.backend.go.goals.check import GoCheckFieldSet, GoCheckRequest
from pants.backend.go.target_types import GoModTarget, GoPackageTarget
from pants.backend.go.util_rules import (
    assembly,
    build_pkg,
    build_pkg_target,
    first_party_pkg,
    go_mod,
    import_analysis,
    link,
    sdk,
    third_party_pkg,
)
from pants.core.goals.check import CheckResult, CheckResults
from pants.engine.addresses import Address
from pants.testutil.rule_runner import QueryRule, RuleRunner


@pytest.fixture
def rule_runner() -> RuleRunner:
    rule_runner = RuleRunner(
        rules=[
            *check.rules(),
            *sdk.rules(),
            *assembly.rules(),
            *build_pkg.rules(),
            *build_pkg_target.rules(),
            *import_analysis.rules(),
            *link.rules(),
            *go_mod.rules(),
            *first_party_pkg.rules(),
            *third_party_pkg.rules(),
            *target_type_rules.rules(),
            QueryRule(CheckResults, [GoCheckRequest]),
        ],
        target_types=[GoModTarget, GoPackageTarget],
    )
    rule_runner.set_options([], env_inherit={"PATH"})
    return rule_runner


def test_check(rule_runner: RuleRunner) -> None:
    rule_runner.write_files(
        {
            "go.mod": dedent(
                """\
                module example.com/greeter
                go 1.17
                """
            ),
            "BUILD": "go_mod(name='mod')",
            "bad/f.go": "invalid!!!",
            "bad/BUILD": "go_package()",
            "good/f.go": dedent(
                """\
                package greeter

                import "fmt"

                func Hello() {
                    fmt.Println("Hello world!")
                }
                """
            ),
            "good/BUILD": "go_package()",
        }
    )
    targets = [rule_runner.get_target(Address("bad")), rule_runner.get_target(Address("good"))]
    results = rule_runner.request(
        CheckResults, [GoCheckRequest(GoCheckFieldSet.create(tgt) for tgt in targets)]
    ).results
    assert set(results) == {CheckResult(1, "", "")}

1	# Copyright 2021 Pants project contributors (see CONTRIBUTORS.md).
2	# Licensed under the Apache License, Version 2.0 (see LICENSE).
3
4	from __future__ import annotations	1✔
5
6	from textwrap import dedent	1✔
7
8	import pytest	1✔
9
10	from pants.backend.go import target_type_rules	1✔
11	from pants.backend.go.goals import check	1✔
12	from pants.backend.go.goals.check import GoCheckFieldSet, GoCheckRequest	1✔
13	from pants.backend.go.target_types import GoModTarget, GoPackageTarget	1✔
14	from pants.backend.go.util_rules import (	1✔
15	assembly,
16	build_pkg,
17	build_pkg_target,
18	first_party_pkg,
19	go_mod,
20	import_analysis,
21	link,
22	sdk,
23	third_party_pkg,
24	)
25	from pants.core.goals.check import CheckResult, CheckResults	1✔
26	from pants.engine.addresses import Address	1✔
27	from pants.testutil.rule_runner import QueryRule, RuleRunner	1✔
28
29
30	@pytest.fixture	1✔
31	def rule_runner() -> RuleRunner:	1✔
32	rule_runner = RuleRunner(	1✔
33	rules=[
34	*check.rules(),
35	*sdk.rules(),
36	*assembly.rules(),
37	*build_pkg.rules(),
38	*build_pkg_target.rules(),
39	*import_analysis.rules(),
40	*link.rules(),
41	*go_mod.rules(),
42	*first_party_pkg.rules(),
43	*third_party_pkg.rules(),
44	*target_type_rules.rules(),
45	QueryRule(CheckResults, [GoCheckRequest]),
46	],
47	target_types=[GoModTarget, GoPackageTarget],
48	)
49	rule_runner.set_options([], env_inherit={"PATH"})	1✔
50	return rule_runner	1✔
51
52
53	def test_check(rule_runner: RuleRunner) -> None:	1✔
54	rule_runner.write_files(	1✔
55	{
56	"go.mod": dedent(
57	"""\
58	module example.com/greeter
59	go 1.17
60	"""
61	),
62	"BUILD": "go_mod(name='mod')",
63	"bad/f.go": "invalid!!!",
64	"bad/BUILD": "go_package()",
65	"good/f.go": dedent(
66	"""\
67	package greeter
68
69	import "fmt"
70
71	func Hello() {
72	fmt.Println("Hello world!")
73	}
74	"""
75	),
76	"good/BUILD": "go_package()",
77	}
78	)
79	targets = [rule_runner.get_target(Address("bad")), rule_runner.get_target(Address("good"))]	1✔
80	results = rule_runner.request(	1✔
81	CheckResults, [GoCheckRequest(GoCheckFieldSet.create(tgt) for tgt in targets)]
82	).results
UNCOV 83	assert set(results) == {CheckResult(1, "", "")}	×

pantsbuild / pants / 18822648545

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous