18812500213

Committed 26 Oct 2025 03:42AM UTC coverage: 80.284% (+0.005%) from 80.279%

Build # 18812500213

Build Type

Pull #22804

github

Committed by

web-flow

Commit Message

Merge 2a56fdb46 into 4834308dc

Pull Request Pull Request #22804: test_shell_command: use correct default cache scope for a test's environment

Run Details

29 of 31 new or added lines in 2 files covered. (93.55%)

1314 existing lines in 64 files now uncovered.

77900 of 97030 relevant lines covered (80.28%)

3.35 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

74.47

/src/python/pants/backend/javascript/goals/lockfile.py

1	# Copyright 2023 Pants project contributors (see CONTRIBUTORS.md).
2	# Licensed under the Apache License, Version 2.0 (see LICENSE).
UNCOV 3	from __future__ import annotations	1✔
4
UNCOV 5	import os.path	1✔
UNCOV 6	from collections.abc import Iterable	1✔
UNCOV 7	from dataclasses import dataclass	1✔
8
UNCOV 9	from pants.backend.javascript import nodejs_project_environment	1✔
UNCOV 10	from pants.backend.javascript.nodejs_project import AllNodeJSProjects, NodeJSProject	1✔
UNCOV 11	from pants.backend.javascript.nodejs_project_environment import (	1✔
12	NodeJsProjectEnvironment,
13	NodeJsProjectEnvironmentProcess,
14	)
UNCOV 15	from pants.backend.javascript.package_json import PackageJsonTarget	1✔
UNCOV 16	from pants.backend.javascript.resolve import NodeJSProjectResolves	1✔
UNCOV 17	from pants.backend.javascript.subsystems.nodejs import UserChosenNodeJSResolveAliases	1✔
UNCOV 18	from pants.core.goals.generate_lockfiles import (	1✔
19	GenerateLockfile,
20	GenerateLockfileResult,
21	KnownUserResolveNames,
22	KnownUserResolveNamesRequest,
23	RequestedUserResolveNames,
24	UserGenerateLockfiles,
25	)
UNCOV 26	from pants.core.goals.tailor import TailorGoal	1✔
UNCOV 27	from pants.engine.internals.native_engine import AddPrefix	1✔
UNCOV 28	from pants.engine.intrinsics import add_prefix	1✔
UNCOV 29	from pants.engine.process import fallible_to_exec_result_or_raise	1✔
UNCOV 30	from pants.engine.rules import Rule, collect_rules, implicitly, rule	1✔
UNCOV 31	from pants.engine.unions import UnionRule	1✔
UNCOV 32	from pants.util.docutil import bin_name	1✔
UNCOV 33	from pants.util.ordered_set import FrozenOrderedSet	1✔
UNCOV 34	from pants.util.strutil import pluralize, softwrap	1✔
35
36
UNCOV 37	@dataclass(frozen=True)	1✔
UNCOV 38	class GeneratePackageLockJsonFile(GenerateLockfile):	1✔
UNCOV 39	project: NodeJSProject	1✔
40
41
UNCOV 42	class KnownPackageJsonUserResolveNamesRequest(KnownUserResolveNamesRequest):	1✔
UNCOV 43	pass	1✔
44
45
UNCOV 46	class RequestedPackageJsonUserResolveNames(RequestedUserResolveNames):	1✔
UNCOV 47	pass	1✔
48
49
UNCOV 50	@rule	1✔
UNCOV 51	async def determine_package_json_user_resolves(	1✔
52	_: KnownPackageJsonUserResolveNamesRequest,
53	all_projects: AllNodeJSProjects,
54	user_chosen_resolves: UserChosenNodeJSResolveAliases,
55	) -> KnownUserResolveNames:
56	names = FrozenOrderedSet(	×
57	user_chosen_resolves.get(
58	os.path.join(project.root_dir, project.lockfile_name), project.default_resolve_name
59	)
60	for project in all_projects
61	)
62	unmatched_aliases = set(user_chosen_resolves.values()).difference(names)	×
63	if unmatched_aliases:	×
64	projects = pluralize(len(unmatched_aliases), "project", include_count=False)	×
65	lockfiles = ", ".join(	×
66	lockfile
67	for lockfile, alias in user_chosen_resolves.items()
68	if alias in unmatched_aliases
69	)
70	paths = pluralize(len(unmatched_aliases), "path", include_count=False)	×
71	raise ValueError(	×
72	softwrap(
73	f"""
74	No nodejs {projects} could be found for {lockfiles}, but
75	some are configured under [nodejs].resolves.
76
77	Ensure that a package.json file you intend to manage with pants has
78	a corresponding BUILD file containing a `{PackageJsonTarget.alias}` target
79	by running `{bin_name()} {TailorGoal.name} ::`.
80
81	Also confirm that {lockfiles} would be generated by your
82	chosen nodejs package manager at the specified {paths}.
83	"""
84	)
85	)
86
87	return KnownUserResolveNames(	×
88	names=tuple(names),
89	option_name="[nodejs].resolves",
90	requested_resolve_names_cls=RequestedPackageJsonUserResolveNames,
91	)
92
93
UNCOV 94	@rule	1✔
UNCOV 95	async def setup_user_lockfile_requests(	1✔
96	resolves: NodeJSProjectResolves,
97	requested: RequestedPackageJsonUserResolveNames,
98	) -> UserGenerateLockfiles:
99	return UserGenerateLockfiles(	×
100	GeneratePackageLockJsonFile(
101	resolve_name=name,
102	lockfile_dest=os.path.join(resolves[name].root_dir, resolves[name].lockfile_name),
103	diff=False,
104	project=resolves[name],
105	)
106	for name in requested
107	)
108
109
UNCOV 110	@rule	1✔
UNCOV 111	async def generate_lockfile_from_package_jsons(	1✔
112	request: GeneratePackageLockJsonFile,
113	) -> GenerateLockfileResult:
114	result = await fallible_to_exec_result_or_raise(	×
115	**implicitly(
116	NodeJsProjectEnvironmentProcess(
117	env=NodeJsProjectEnvironment.from_root(request.project),
118	args=request.project.generate_lockfile_args,
119	description=f"generate {request.project.lockfile_name} for '{request.resolve_name}'.",
120	output_files=(request.project.lockfile_name,),
121	)
122	)
123	)
124	output_digest = await add_prefix(AddPrefix(result.output_digest, request.project.root_dir))	×
125	return GenerateLockfileResult(output_digest, request.resolve_name, request.lockfile_dest)	×
126
127
UNCOV 128	def rules() -> Iterable[Rule \| UnionRule]:	1✔
UNCOV 129	return (	1✔
130	*collect_rules(),
131	*nodejs_project_environment.rules(),
132	UnionRule(GenerateLockfile, GeneratePackageLockJsonFile),
133	UnionRule(KnownUserResolveNamesRequest, KnownPackageJsonUserResolveNamesRequest),
134	UnionRule(RequestedUserResolveNames, RequestedPackageJsonUserResolveNames),
135	)

pantsbuild / pants / 18812500213

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous