maruina / go-infrabin / 18804481427

56%

push

github

Enhance HTTP request logging with proxy-aware source IP tracking (#404)

* Enhance HTTP request logging with proxy-aware source IP tracking

Replaces standard Apache Combined Log Format with an enhanced version that properly handles proxy headers (X-Real-IP, X-Forwarded-For) for accurate source IP logging.

## Changes

- Add `pkg/infrabin/logging.go` with custom log formatter
  - `RequestLoggingFormatter`: Extends Apache Combined Log Format
  - `getSourceIP`: Extracts client IP from proxy headers
- Update `pkg/infrabin/http.go` to use custom logging handler
  - Replace `CombinedLoggingHandler` with `CustomLoggingHandler`
  - Apply custom formatter for enhanced logging

## Log Format

sourceIP - remoteUser [timestamp] "method path protocol" statusCode size "referer" "userAgent"

## Benefits

- Accurate client IP logging behind proxies/load balancers
- Full Apache Combined format compatibility
- All request metadata preserved (size, user-agent, referer, protocol)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Fix errcheck linter: explicitly ignore fmt.Fprintf error

The LogFormatter signature doesn't allow error returns, and logging
failures shouldn't impact request handling. Following idiomatic Go
practice by explicitly acknowledging the ignored error with blank
identifiers.

---------

Co-authored-by: Claude <noreply@anthropic.com>

0 of 48 new or added lines in 2 files covered. (0.0%)

354 of 694 relevant lines covered (51.01%)

3.19 hits per line