mindersec / minder / 18789261419
58%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 335
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 57.972% (-0.003%) from 57.975%
18789261419

push

github

web-flow 
Phase 3: Drop legacy columns from evaluation_rule_entities (#5931)

* Phase 3: Drop legacy columns from evaluation_rule_entities

This migration removes the legacy entity ID columns (repository_id,
pull_request_id, artifact_id) from the evaluation_rule_entities table.
These columns have been replaced by the unified entity_instance_id column.

Background:
- Migration 095 added entity_instance_id as nullable
- Migration 097 made entity_instance_id NOT NULL (all rows migrated)
- Migration 104 dropped the one_entity_id constraint
- All queries now use entity_instance_id exclusively

Changes:
- Created migration 000113_drop_eval_legacy_columns
- Regenerated Go structs (EvaluationRuleEntity simplified)
- All tests passing
- All lint checks passing

Part of the legacy table removal plan (Phase 3 of 4).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Add data recovery SQL to down migration

The down migration now properly restores legacy column data by joining
through entity_instances. Since entity_instances.id uses the same UUID
as the legacy table IDs, we can recover the data with simple UPDATE
statements.

Recovery logic:
- Joins evaluation_rule_entities to entity_instances via entity_instance_id
- Uses entity_type to determine which legacy column to populate
- Verifies the legacy table row exists before updating

This addresses the reviewer's concern about manual recovery being needed.

---------

Co-authored-by: Claude <noreply@anthropic.com>

18863 of 32538 relevant lines covered (57.97%)

37.16 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
69.7
 -0.3% internal/authz/authz.go
Jobs
ID Job ID Ran Files Coverage
1 18789261419.1 335
57.97
 GitHub Action Run
Source Files on build 18789261419