facebookincubator / TTPForge / 18789212967

66%

main: 67%

Pull #571

github

Fix bug with path arg type and add env var expansion (#571)

Summary:

The path arg type was not being evaluated based on the path of the TTP YAML. This caused relative paths such as `default: <FILE>` or `default: ./<FILE>` to resolve based on the path you executed ttpforge from as opposed to the path of the YAML.

This has been updated to resolve relative to the YAML when provided as a default value and resolve relative to the current working directory when provided as a command-line argument.

Additionally added handling for variable expansion within the shell. This should be helpful for TTPs referencing variables like $HOME or alike.

Reviewed By: RoboticPrism

Differential Revision: D85156301

27 of 45 new or added lines in 6 files covered. (60.0%)

2747 of 4185 relevant lines covered (65.64%)

16.7 hits per line