18765396043
73%

Ran 24 Oct 2025 02:41AM UTC

Jobs 1

Files 1962

Run time 4min

Badge

Embed ▾

Committed 23 Oct 2025 01:51PM UTC coverage: 72.284% (-0.01%) from 72.295%

Build # 18765396043

Build Type

push

github

Committed by

YHNdnzj

Commit Message

core: increment start limit counter only when we can start the unit

Otherwise, e.g. requesting to start a unit that is under stopping may
enter the failed state.

This makes
- rename .can_start() -> .test_startable(), and make it allow to return
  boolean and refuse to start units when it returns false,
- refuse earlier to start units that are in the deactivating state, so
  several redundant conditions in .start() can be dropped,
- move checks for unit states mapped to UNIT_ACTIVATING from .start() to
  .test_startable().

Fixes #39247.

Run Details

13 of 15 new or added lines in 8 files covered. (86.67%)

6946 existing lines in 72 files now uncovered.

304970 of 421905 relevant lines covered (72.28%)

1105466.04 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
2	36.7	0.05%	src/core/swap.c

Uncovered Existing Lines

Lines	Coverage	∆	File
1	82.0	-2.0%	src/basic/errno-util.h
1	80.26	-0.15%	src/basic/fs-util.c
1	76.87	-0.68%	src/basic/io-util.c
1	83.07	-0.09%	src/basic/process-util.c
1	59.52	0.0%	src/core/dbus-job.c
1	36.7	0.05%	src/core/swap.c
1	73.91	-4.35%	src/libsystemd-network/lldp-network.c
1	80.43	-0.36%	src/libsystemd-network/sd-ndisc.c
1	90.5	-0.16%	src/libsystemd/sd-device/device-enumerator.c
1	71.93	-0.58%	src/login/logind-varlink.c
1	70.18	-0.12%	src/resolve/resolved-dns-scope.c
1	76.32	-0.16%	src/resolve/resolved-dns-server.c
1	79.63	0.0%	src/resolve/resolved-dns-transaction.c
1	70.02	-0.16%	src/systemctl/systemctl-list-units.c
2	87.7	-0.82%	src/basic/pidref.c
2	87.5	19.52%	src/coredump/coredump.c
2	78.49	2.64%	src/journal-remote/journal-upload-journal.c
2	87.65	-0.62%	src/libsystemd-network/sd-lldp-tx.c
2	92.12	-0.1%	src/libsystemd/sd-journal/journal-file.c
2	76.07	-0.31%	src/resolve/resolved-dns-stub.c
2	79.6	-0.8%	src/shared/rm-rf.c
2	28.8	-0.26%	src/udev/udev-builtin-net_id.c
2	81.0	-0.48%	src/udev/udev-node.c
3	85.31	0.19%	src/network/networkd-link.c
3	77.97	-0.26%	src/resolve/resolved-manager.c
3	72.51	0.19%	src/shared/discover-image.c
4	73.14	-0.14%	src/core/cgroup.c
4	91.49	-8.51%	src/core/unit.h
4	40.27	-0.19%	src/login/logind-dbus.c
4	81.73	-0.99%	src/network/networkd-sysctl.c
4	98.72	0.0%	src/resolve/test-dns-cache.c
5	61.52	-1.36%	src/core/scope.c
5	69.14	-0.28%	src/network/networkd-ndisc.c
6	0.0	0.0%	src/fuzz/fuzz.h
6	64.01	-0.82%	src/libsystemd/sd-journal/journal-verify.c
6	84.65	-2.63%	src/shared/journal-file-util.c
7	65.0	-10.0%	src/basic/assert-util.c
11	66.88	-0.67%	src/import/export.c
11	79.05	-10.48%	src/shared/utmp-wtmp.c
12	80.85	1.42%	src/udev/udevadm-lock.c
13	77.38	-1.61%	src/core/job.c
13	0.0	0.0%	src/vmspawn/vmspawn-mount.c
15	87.22	0.0%	src/shared/machine-bind-user.c
26	64.64	-0.71%	src/core/service.c
34	79.4	-4.03%	src/import/import-tar.c
34	58.27	0.06%	src/mountfsd/mountfsd-manager.c
35	73.18	-0.93%	src/import/import-fs.c
36	57.58	-7.03%	src/shared/install-file.c
39	91.06	0.87%	src/libsystemd/sd-device/sd-device.c
42	63.22	0.12%	src/userdb/userdbd-manager.c
56	76.84	0.68%	src/shared/blockdev-util.c
63	66.29	-0.51%	src/import/import.c
70	73.93	-1.07%	src/udev/udev-watch.c
75	80.78	-0.14%	src/varlinkctl/varlinkctl.c
79	63.5	-0.16%	src/nsresourced/nsresourced-manager.c
80	65.67	-0.42%	src/import/pull.c
83	47.74	0.8%	src/socket-activate/socket-activate.c
100	0.0	0.0%	src/import/import-generator.c
102	46.36	-15.07%	src/import/import-common.c
114	73.05	-0.09%	src/shared/copy.c
117	60.88	-4.93%	src/import/pull-tar.c
130	60.85	0.3%	src/libsystemd/sd-daemon/sd-daemon.c
172	65.14	-0.99%	src/import/importctl.c
189	73.86	-0.65%	src/import/importd.c
326	79.68	-1.22%	src/core/manager.c
363	80.88	-0.04%	src/libsystemd/sd-varlink/sd-varlink.c
416	77.12	-1.5%	src/shared/dissect-image.c
611	70.25	0.04%	src/core/exec-invoke.c
654	74.35	0.0%	src/nspawn/nspawn.c
720	0.0	0.0%	src/vmspawn/vmspawn.c
923	0.24	0.0%	src/home/homework-luks.c
1086	71.16	-0.08%	src/repart/repart.c

Jobs

ID	Job ID	Ran	Files	Coverage
1	18765396043.1	24 Oct 2025 02:41AM UTC	1962	72.28	GitHub Action Run

systemd / systemd / 18765396043
73%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 18765396043

systemd / systemd / 18765396043 73%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 18765396043

systemd / systemd / 18765396043
73%

README BADGES
x