rm-hull / placenames-api / 18756189593

53%

push

github

Improve test coverage (#5)

* Improve test coverage

* Add checks on the returned errors

* Tighten up the test

* feat: Add comprehensive tests for LoadData

Adds a new test suite for the `LoadData` function in `internal/trie.go`.

The new tests cover:
- Successful data loading
- File not found errors
- Invalid gzip file format
- CSV records with incorrect number of fields
- CSV records with invalid relevancy values
- Integration test with the full dataset

The error assertions have been made more specific to ensure the correct errors are returned. The `LoadData` function was also updated to allow for more robust error handling of malformed CSV records.

* Additional tests; remove unreachable code

* Counting error

* Additional tests; dont insert duplicates

14 of 14 new or added lines in 1 file covered. (100.0%)

87 of 195 relevant lines covered (44.62%)

0.55 hits per line