pulibrary / orangelight / f87eb836-0f85-451e-aa5b-76b75f782b4f

95%

main: 95%

Pull #5254

circleci

Refactor: move Requestable creation out of Requests::Form

Prior to this commit, one of the Form class' many
responsibilities was to create many of the
Requestable instances needed by the Requests system.
It created four different kinds of Requestable, and
it was hard to trace the logic throughout the Form
class for each one of those four paths.

This commit takes a different approach: introducing
a factory class named RequestablesList, which
determines what type of Requestable to create,
then delegates the creation to one of four smaller
factories: AlmaItemsFactory, ScsbItemsFactory,
NoItemsFactory, and TooManyItemsFactory.

158 of 159 new or added lines in 7 files covered. (99.37%)

6147 of 6448 relevant lines covered (95.33%)

1499.66 hits per line