stacklok / toolhive / 18731984782

50%

Build Type

push

github

Committed by web-flow

Commit Message

Reduce MCPServer CRD size by using runtime.RawExtension for PodTemplateSpec (#2015)

* Reduce MCPServer CRD size by using runtime.RawExtension for PodTemplateSpec

The MCPServer CRD was too large (~9500 lines) to apply without server-side
apply due to the embedded PodTemplateSpec taking up ~8500 lines. This was
causing issues as reported in GitHub issue #2013.

Changed the PodTemplateSpec field from a strongly-typed corev1.PodTemplateSpec
to runtime.RawExtension, which stores the raw JSON without schema validation
at the CRD level. This reduces the CRD size from ~9500 lines to 651 lines
(93% reduction).

The solution maintains full backwards compatibility - users can still use
the same YAML structure. Validation now happens at runtime in the operator,
with proper error handling via Kubernetes events and status conditions to
notify users when invalid PodTemplateSpec data is provided.

Key changes:
- Modified MCPServer type to use runtime.RawExtension for PodTemplateSpec
- Updated PodTemplateSpecBuilder to unmarshal and validate at runtime
- Added event recording and status conditions for validation errors
- Added comprehensive tests for invalid PodTemplateSpec scenarios
- Fixed race conditions in parallel tests

Fixes #2013

* Bump operator-crds chart version to 0.0.40

The CRD has been modified (MCPServer.spec.podTemplateSpec changed to
runtime.RawExtension), so the chart version needs to be bumped per
CI requirements.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Address PR feedback from code review

Fixes based on Copilot and reviewer feedback:
- Fix DeepCopy call to use pointer: (&userTemplate).DeepCopy()
- Remove duplicate test assertions in pod template tests
- Remove redundant PodTemplateSpec check in deploymentNeedsUpdate
- Remove ~200 lines of dead code (non-ConfigMap mode paths)
- Remove 5 unused functions (getProxyHost, generateOIDCArgs, etc.)
- Improve isEmpty() to check a... (continued)

Run Details

141 of 168 new or added lines in 5 files covered. (83.93%)

1 existing line in 1 file now uncovered.

18673 of 39644 relevant lines covered (47.1%)

15.63 hits per line