nbari / pg_exporter / 18629635093

90%

main: 90%

push

github

refactor: improve CLI test maintainability with RAII guards

Added helper functions to reduce boilerplate and improve safety:

1. ChildGuard: RAII guard ensures automatic process cleanup on scope exit,
   preventing resource leaks even if tests panic or return early.

2. start_and_wait(): Combines start + wait logic, reducing repetition
   across 5 async tests. Returns Result for better error propagation.

3. http_get(): Centralizes HTTP request logic, eliminating duplicate
   client creation and error handling across endpoint tests.

Benefits:
- Reduced code by 12 lines (83 deleted, 71 added)
- Eliminated manual cleanup_child() calls in most tests
- Automatic cleanup even on early returns or panics
- Better error messages (uses anyhow::bail with context)
- More readable tests focusing on behavior, not boilerplate
- Consistent HTTP handling across all endpoint tests

All tests still pass in 3.70s locally.

45 of 48 new or added lines in 1 file covered. (93.75%)

3941 of 4527 relevant lines covered (87.06%)

32.85 hits per line