bitcoindevkit / bdk / 18629345790

79%

push

github

Merge bitcoindevkit/bdk#2056: fix(core) `Checkpoint::drop` memory leak

<a class=hub.com/bitcoindevkit/bdk/commit/0bd93dad114b90c3f08df9cc892625e250edb718">0bd93dad1 fix(core): Memory leak bugs in `CheckPoint::drop` impl (志宇)

Pull request description:

  based on #1997, depends on #2055

  ### Description

  Fix memory leak bug in CheckPoint::drop by using Arc::into_inner.

  Add tests (from the old PR) for memory leak + stack overflow when dropping CheckPoint.

  ### Notes to the reviewers

  It should be merged after #2055.

  ### Changelog notice

  ```
  ### Fix:
  - Fix memory leak bug in CheckPoint::drop by using `Arc::into_inner`.
  ```

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

  #### Bugfixes:

  * [x] This pull request breaks the existing API
  * [x] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  evanlinjin:
    ACK 0bd93dad114b90c3f08df9cc892625e250edb718

Tree-SHA512: f61bd7ee18e1e7a51b1e4ffe711f3250c90

378 of 512 branches covered (73.83%)

Branch coverage included in aggregate %.

35 of 38 new or added lines in 1 file covered. (92.11%)

4233 of 5347 relevant lines covered (79.17%)

3278.5 hits per line