agentjido / req_llm / 5379266960137e23e60be69727356e1bde1672d2

49%

Build Type

push

github

Committed by web-flow

Commit Message

Fix exceeds_window_size errors with large request bodies (#113)

* Fix Finch HTTP/2 flow control bug with large request bodies

Changes default Finch pool from [:http2, :http1] to [:http1] to avoid
HTTP/2 flow control bug when sending request bodies larger than 64KB.

This is a workaround for https://github.com/sneako/finch/issues/265
where mixed HTTP/1+HTTP/2 protocols cause exceeds_window_size errors
for large request bodies.

Adds safety validation that prevents HTTP/2 pools from attempting large
requests. If user configures HTTP/2 and tries to send >64KB body, returns
helpful error with configuration instructions and README link.

Affects all providers (Anthropic, Bedrock, etc.) when sending large
prompts or context windows. Users can override to HTTP/2 for small
payloads if needed.

* Add tests for HTTP/2 error handling and validation

Introduces two new test modules: HTTP2ErrorMessageTest and HTTP2ValidationTest.

- HTTP2ErrorMessageTest verifies logging of helpful error messages when large request bodies are sent to HTTP/2 pools, ensuring users receive clear guidance on configuration limits.
- HTTP2ValidationTest checks the behavior of small and large request bodies with HTTP/2 pools, confirming that large requests are blocked and appropriate errors are raised.

These tests enhance coverage for HTTP/2 handling, addressing potential issues with large payloads and improving user experience through informative logging and error management.

---------

Co-authored-by: Mike Hostetler <84222+mikehostetler@users.noreply.github.com>

Run Details

19 of 22 new or added lines in 2 files covered. (86.36%)

5 existing lines in 2 files now uncovered.

3295 of 6534 relevant lines covered (50.43%)

445.68 hits per line