get2knowio / deacon / 18616591641
87%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 32
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 87.5%. Remained the same
18616591641

push

github

web-flow 
fix: [read-configuration] CLI Flags: Docker tooling paths and mount/workspace options (#376)

* Initial commit for issue #292

* feat: Add terminal dimensions and user data folder options to read-configuration command

* fix: Add comprehensive tests and documentation for new CLI flags

- Add #[allow(dead_code)] with detailed comments explaining why docker_path,
  docker_compose_path, and user_data_folder are accepted per spec but not yet
  consumed by implementation. These fields are included for CLI parity per issue #292.

- Add comprehensive test coverage for terminal dimensions validation:
  * test_terminal_dimensions_both_provided: Validates that both columns and rows work
  * test_terminal_dimensions_only_columns: Ensures pairing requirement is enforced
  * test_terminal_dimensions_only_rows: Ensures pairing requirement is enforced
  * test_terminal_dimensions_neither_provided: Validates optional behavior

- Add tests for docker paths and user_data_folder:
  * test_docker_paths_default_values: Verify 'docker' and 'docker-compose' defaults
  * test_docker_paths_custom_values: Verify custom paths are accepted and stored
  * test_user_data_folder_optional: Verify None case
  * test_user_data_folder_with_value: Verify path storage

All tests pass (32 tests in read_configuration module).
Clippy passes with -D warnings. Code is properly formatted.

Fixes blocking issues from senior review:
- Resolves clippy dead_code warnings treated as errors
- Adds complete test coverage for new validation logic
- Adds documentation for spec alignment

7000 of 8000 relevant lines covered (87.5%)

425.1 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
10
74.07
 0.0% crates/deacon/src/cli.rs
Jobs
ID Job ID Ran Files Coverage
1 18616591641.1 32
87.5
 GitHub Action Run
Source Files on build 18616591641