mindersec / minder / 18601097126

58%

Build Type

push

github

Committed by web-flow

Commit Message

Phase 1 + 2: Remove legacy table writes and migrate reads (#5913)

* Phase 1: Remove legacy table dual writes

This commit implements Phase 1 of the legacy table removal plan,
eliminating dual writes to the deprecated repositories, artifacts,
and pull_requests tables while maintaining backward compatibility
for read operations.

Changes:
- Remove CreateRepository() calls that wrote to legacy repositories table
- Remove UpsertArtifact() calls that wrote to legacy artifacts table
- Remove DeleteRepository() calls from deletion flow
- Update all write operations to only use entity_instances and properties tables
- Update test mocks to reflect new database interaction patterns
- Fix linter warnings for unused parameters

All repository and entity tests are passing. The system now writes
exclusively to the unified entity model, preparing for Phase 2 where
read operations will be migrated.

Related to legacy table removal plan documented in LEGACY_TABLE_REMOVAL_PLAN.md

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Phase 2: Migrate all reads to entity_instances and properties tables

This commit completes Phase 2 of the legacy table removal plan by migrating
all read operations from the legacy repositories, artifacts, and pull_requests
tables to the unified entity_instances and properties tables.

Combined with Phase 1 (stop writes), this PR now safely removes all dependencies
on legacy tables without breaking any functionality.

Key Changes:

Repository Service:
- Updated GetRepositoryById to query entity_instances + properties
- Updated GetRepositoryByName to search by name property
- Updated DeleteByName to use property-based entity search
- Changed return types from db.Repository to *pb.Repository

Artifact Handlers:
- Updated GetArtifactById and GetArtifactByName to use entity_instances
- Updated ListArtifacts to query entity_instances directly
- Removed legacy helper functions

Reposi... (continued)

Run Details

112 of 286 new or added lines in 8 files covered. (39.16%)

3 existing lines in 2 files now uncovered.

18863 of 32538 relevant lines covered (57.97%)

37.02 hits per line