tari-project / tari / 18586282491
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 700
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 58.577% (-1.0%) from 59.552%
18586282491

push

github

web-flow 
fix: change how pagination works on utxo scanning (#7546)

Description
---
Properly handle the special edge case, where the request has reached the
page limit, but we are also not done with the block. We also dont want
to split up the block over two requests. So we need to ensure that we
remove the partial block we added so that it can be requested fully in
the next request. We also dont want to get in a loop where the block
cannot fit into the page limit, so if the block is the same as the first
one, we just send it as it, partial. If net we remove it and let it be
sent in the next request.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Bug Fixes**
* Fixed edge cases in paginated UTXO queries when a page ends mid-block
to prevent partial or duplicated results.
* Ensures correct continuation across block boundaries and early exit
when the first block is also the last that can be sent.
* Removes trailing blocks or partial entries so subsequent pages request
the correct data.
  * Improves error reporting for rare pagination inconsistencies.
* Preserves behavior when limits aren’t reached or the chain end is
encountered.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

0 of 10 new or added lines in 1 file covered. (0.0%)

1137 existing lines in 32 files now uncovered.

66481 of 113494 relevant lines covered (58.58%)

228684.39 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
10
0.0
 0.0% base_layer/core/src/base_node/rpc/query_service.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
98.88
 -1.12% base_layer/common_types/src/dammsum.rs
1
63.32
 -0.27% base_layer/core/src/mempool/sync_protocol/mod.rs
1
93.76
 -0.19% base_layer/core/src/proof_of_work/monero_rx/merkle_tree.rs
1
91.09
 -0.99% base_layer/transaction_components/src/consensus/consensus_encoding/hashing.rs
1
88.44
 -0.29% comms/core/src/multiplexing/yamux.rs
3
26.09
 -13.04% base_layer/common_types/src/epoch.rs
3
38.57
 -4.29% base_layer/core/src/validation/mocks.rs
3
31.71
 -7.32% base_layer/node_components/src/blocks/block_header_accumulated_data.rs
3
46.51
 -6.98% base_layer/node_components/src/blocks/historical_block.rs
3
20.0
 -5.0% infrastructure/test_utils/src/streams/mod.rs
4
0.0
 -23.53% base_layer/core/src/base_node/proto/rpc.rs
4
88.64
 -4.55% base_layer/core/src/test_helpers/block_spec.rs
4
79.55
 -0.61% comms/core/src/noise/socket.rs
5
85.19
 -4.63% base_layer/core/src/common/rolling_vec.rs
5
71.05
 -6.58% base_layer/core/src/consensus/chain_strength_comparer.rs
6
73.53
 -8.82% base_layer/common_types/src/types/fixed_hash.rs
8
0.0
 -15.38% base_layer/core/src/validation/error.rs
9
91.51
 -0.97% base_layer/transaction_components/src/consensus/consensus_constants.rs
11
50.0
 -50.0% base_layer/core/src/chain_storage/smt_hasher.rs
11
54.72
 -0.69% comms/core/src/connectivity/manager.rs
12
48.73
 -4.36% base_layer/core/src/chain_storage/db_transaction.rs
12
85.1
 -1.39% base_layer/core/src/chain_storage/lmdb_db/validator_node_store.rs
17
36.47
 -10.0% base_layer/transaction_components/src/transaction_components/output_features.rs
20
0.0
 -26.32% base_layer/transaction_components/src/transaction_components/side_chain/sidechain_feature.rs
20
67.62
 -19.05% base_layer/transaction_components/src/transaction_components/side_chain/validator_node_registration.rs
21
61.43
 -5.16% base_layer/core/src/chain_storage/lmdb_db/lmdb.rs
22
8.7
 -31.88% base_layer/core/src/chain_storage/block_add_result.rs
26
61.13
 -3.86% base_layer/core/src/test_helpers/blockchain.rs
29
63.75
 -36.25% base_layer/core/src/base_node/sync/rpc/tests.rs
55
12.27
 -14.36% base_layer/core/src/base_node/sync/rpc/service.rs
341
41.46
 -11.76% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
475
39.11
 -16.56% base_layer/core/src/chain_storage/blockchain_database.rs
Jobs
ID Job ID Ran Files Coverage
1 18586282491.1 700
58.58
 GitHub Action Run
Source Files on build 18586282491