18583762443
37%
main: 45%

Ran 17 Oct 2025 05:50AM UTC

Jobs 1

Files 230

Run time 1min

Badge

Embed ▾

Committed 17 Oct 2025 05:38AM UTC coverage: 37.216% (+0.02%) from 37.197%

Build # 18583762443

Build Type

push

github

Committed by

cdesiniotis

Commit Message

[nvidia-ctk-installer] do not revert cri-o config on shutdown

This commit updates the behavior of the nvidia-ctk-installer for cri-o.
On shutdown, we no longer delete the drop-in config file as long as
none of the nvidia runtime handlers are set as the default runtime.
This change was made to workaround an issue observed when uninstalling
the gpu-operator -- management containers launched with the nvidia
runtime handler would get stuck in the terminating state with the below
error message:

```
failed to find runtime handler nvidia from runtime list map[crun:... runc:...], failed to "KillPodSandbox" for ...
```

There appears to be a race condition where the nvidia-ctk-installer removes the drop-in file
and restarts cri-o. After the cri-o restart, if there are still pods / containers to terminate
that were started with the nvidia runtime, then cri-o fails to terminate them. The behavior
of cri-o, and its in-memory runtime handler cache, appears to differ from that of containerd as
we have never encountered such an issue with containerd.

This commit can be considered a stop-gap solution until more robust solution is developed.

Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>

Coverage Stats

4981 of 13384 relevant lines covered (37.22%)

0.42 hits per line

Coverage Regressions

Lines	Coverage	∆	File
9	50.76	1.54%	cmd/nvidia-ctk-installer/container/runtime/crio/crio.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	18583762443.1	17 Oct 2025 05:50AM UTC	230	37.22	GitHub Action Run

NVIDIA / nvidia-container-toolkit / 18583762443
37%
main: 45%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 18583762443

NVIDIA / nvidia-container-toolkit / 18583762443 37% main: 45%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 18583762443

NVIDIA / nvidia-container-toolkit / 18583762443
37%
main: 45%

README BADGES
x