NVIDIA / gpu-operator / 18577663240

22%

main: 22%

Build Type

push

github

Committed by cdesiniotis

Commit Message

Revert back to using the hook on cri-o when CDI is disabled

When CDI is not enabled and cri-o is the container runtime,
we continue to install the OCI prestart hook as opposed to adding nvidia
runtime handlers to the cri-o configuration. Users can override this behavior
and have nvidia runtime handlers added to the cri-o configuration by setting
the 'CRIO_CONFIG_MODE' environment variable to 'config' in the toolkit container.
However, one should note setting 'CRIO_CONFIG_MODE' to 'config' in this case
(when CDI is not enabled) would result in the 'nvidia' runtime being set as
the default runtime. While this should work in theory, it is a significant
change -- which was the primary motivation to continue using the OCI prestart
hook by default in this case.

Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>

Run Details

10 of 24 new or added lines in 1 file covered. (41.67%)

1 existing line in 1 file now uncovered.

2601 of 11665 relevant lines covered (22.3%)

0.25 hits per line