18574443117
4%

Ran 16 Oct 2025 08:52PM UTC

Jobs 1

Files 63

Run time 8min

Badge

Embed ▾

Committed 16 Oct 2025 08:50PM UTC coverage: 4.438% (-0.8%) from 5.235%

Build # 18574443117

Build Type

push

github

Committed by

web-flow

Commit Message

Panic on GNMI delete with union leafs (#167)

This patch modifies `pathgen/gnmigen.go` to check if the reflect value is valid before calling IsZero(). In the case of YANG union values, an uninitialized interface can be passed to reflect.ValueOf() which is one of the few cases it can return a zero value. This condition seems to exist only when a GNMI message is received that contains enough for a struct to be allocated but not enough for values to be populated (DELETE on a YANG keyed list).

A new test case is added to `ygnmi/ygnmi_test.go` which utilizes the modified YANG schema in `pathgen/testdata/yang/openconfig-unione.yang` to trigger the failure.

Run Details

2 of 8107 new or added lines in 42 files covered. (0.02%)

2 existing lines in 2 files now uncovered.

2313 of 52114 relevant lines covered (4.44%)

0.05 hits per line

New Missed Lines in Diff

Lines	∆	File
2	0.0%	internal/gnmitestutil/gnmi.go
8	0.0%	exampleoc/a/a-0.go
8	0.0%	internal/exampleocconfig/a/a-0.go
8	0.0%	internal/exampleocunordered/withlistval/withlistval-0.go
8	0.0%	internal/examplesetorigin/setpathorigin/a/a-0.go
8	0.0%	internal/examplesetorigin/usemodulenameaspathorigin/a/a-0.go
8	0.0%	internal/uexampleoc/a/a-0.go
16	0.0%	exampleoc/enum_map.go
16	0.0%	internal/exampleocconfig/enum_map.go
16	0.0%	internal/exampleocunordered/enum_map.go
16	0.0%	internal/examplesetorigin/setpathorigin/enum_map.go
16	0.0%	internal/examplesetorigin/usemodulenameaspathorigin/enum_map.go
16	0.0%	internal/uexampleoc/enum_map.go
30	0.0%	exampleoc/enum.go
30	0.0%	internal/exampleocconfig/enum.go
30	0.0%	internal/exampleocunordered/enum.go
30	0.0%	internal/exampleocunordered/exampleocunorderedpath/exampleocunorderedpath.go
30	0.0%	internal/examplesetorigin/setpathorigin/enum.go
30	0.0%	internal/examplesetorigin/usemodulenameaspathorigin/enum.go
32	0.0%	internal/exampleocunordered/simple/simple-0.go
32	0.0%	internal/uexampleoc/enum.go
32	0.0%	internal/uexampleoc/simple/simple-0.go
42		exampleoc/union.go
42		internal/exampleocconfig/union.go
42		internal/exampleocunordered/union.go
42		internal/examplesetorigin/setpathorigin/union.go
42		internal/examplesetorigin/usemodulenameaspathorigin/union.go
44		internal/uexampleoc/union.go
54	0.0%	internal/uexampleoc/uexampleocpath/uexampleocpath.go
203	0.0%	exampleoc/structs-0.go
203	0.0%	internal/exampleocconfig/structs-0.go
203	0.0%	internal/exampleocunordered/structs-0.go
203	0.0%	internal/examplesetorigin/setpathorigin/structs-0.go
203	0.0%	internal/examplesetorigin/usemodulenameaspathorigin/structs-0.go
347	0.0%	internal/uexampleoc/structs-0.go
861		internal/exampleocunordered/unione/unione-0.go
1028	0.0%	exampleoc/exampleocpath/exampleocpath.go
1028	0.0%	internal/exampleocconfig/exampleocconfigpath/exampleocconfigpath.go
1028	0.0%	internal/examplesetorigin/setpathorigin/setpathoriginpath/setpathoriginpath.go
1029	0.0%	internal/examplesetorigin/usemodulenameaspathorigin/usemodulenameaspathoriginpath/usemodulenameaspathoriginpath.go
1039		internal/uexampleoc/unione/unione-0.go

Uncovered Existing Lines

Lines	Coverage	∆	File
1	0.0	0.0%	internal/examplesetorigin/usemodulenameaspathorigin/usemodulenameaspathoriginpath/usemodulenameaspathoriginpath.go
1	0.0	0.0%	internal/uexampleoc/structs-0.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	18574443117.1	16 Oct 2025 08:52PM UTC	63	4.44	GitHub Action Run

openconfig / ygnmi / 18574443117
4%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 18574443117

openconfig / ygnmi / 18574443117 4%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 18574443117

openconfig / ygnmi / 18574443117
4%

README BADGES
x