stacklok / toolhive / 18561445936

59%

Build Type

push

github

Committed by web-flow

Commit Message

Refactor OIDC resolver to use generic OIDCConfigurable interface (#2228)

This change makes the OIDC resolver more flexible and reusable across
different resource types by using a generic interface instead of being
tied to MCPServer specifically.

Key changes:
- Add OIDCConfigurable interface with GetName(), GetNamespace(),
  GetOIDCConfig(), and GetPort() methods
- Refactor Resolve() method to accept OIDCConfigurable interface
  instead of MCPServer directly
- Update helper methods (resolveKubernetesConfig and
  resolveConfigMapConfig) to accept namespace string instead of
  MCPServer object
- Implement OIDCConfigurable interface for MCPServer type
- Remove duplicate MCPServer-specific resolution methods

This enables both MCPServer and future resource types (like
MCPRemoteProxy) to share the same OIDC configuration resolution
logic without code duplication. The MCPServer controller continues
to work unchanged, calling resolver.Resolve(ctx, mcpServer).

All existing tests pass without modification.

Run Details

10 of 22 new or added lines in 2 files covered. (45.45%)

2 existing lines in 1 file now uncovered.

17900 of 38276 relevant lines covered (46.77%)

15.73 hits per line