kubeflow / trainer / 18558824991

51%

push

github

feat(runtimes): implement clusterTrainingRuntime deprecation process (#2791)

* constants: add deprecation label constants for runtimes

Signed-off-by: Tarun Duhan <itarunduhan@gmail.com>

* webhooks: warn on creation of deprecated ClusterTrainingRuntime

Signed-off-by: Tarun Duhan <itarunduhan@gmail.com>

* runtime: warn when TrainJob references deprecated ClusterTrainingRuntime

Signed-off-by: Tarun Duhan <itarunduhan@gmail.com>

* tests: add unit test coverage for deprecation warnings

Signed-off-by: Tarun Duhan <itarunduhan@gmail.com>

* webhooks/runtime: update deprecation warning wording and tests

Signed-off-by: Tarun Duhan <itarunduhan@gmail.com>

* constants/webhooks/runtime: centralize runtime policy URL and reference constant

Signed-off-by: Tarun Duhan <itarunduhan@gmail.com>

* tests(integration/webhooks): add create case for deprecated ClusterTrainingRuntime

Create ClusterTrainingRuntime with deprecated label; assert creation succeeds (warning is non-blocking)

Signed-off-by: Tarun Duhan <itarunduhan@gmail.com>

* tests(integration/webhooks): add TrainJob create with deprecated ClusterTrainingRuntime

Mark ClusterTrainingRuntime deprecated; create TrainJob referencing it; assert creation succeeds (warning is non-blocking)

Signed-off-by: Tarun Duhan <itarunduhan@gmail.com>

* tests/runtime: cover deprecation warning in ClusterTrainingRuntime.ValidateObjects

Signed-off-by: Tarun Duhan <itarunduhan@gmail.com>

* tests(integration): remove deprecation-warning cases for CTR/TrainJob webhooks

Signed-off-by: Tarun Duhan <itarunduhan@gmail.com>

* feat(runtimes): switch to support=deprecated and centralize deprecation check

Signed-off-by: Tarun Duhan <itarunduhan@gmail.com>

* tests(webhooks): focus UTs on entrypoints and clean up tests/test data

Signed-off-by: Tarun Duhan <itarunduhan@gmail.com>

* Rename package from labels to trainingruntime

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

---------

Signed-off-by: T... (continued)

9 of 28 new or added lines in 3 files covered. (32.14%)

1263 of 2422 relevant lines covered (52.15%)

0.62 hits per line