safe-global / safe-client-gateway / 18557055253

89%

Build Type

push

github

Committed by web-flow

Commit Message

fix: add SafeMigration contract support for version detection (#2746)

* fix: add SafeMigration contract support for version detection

Extends the migration transaction detection logic to support SafeMigration
contracts in addition to SafeToL2Migration contracts. This fixes the issue
where the Client Gateway couldn't calculate safeTxHash for Safes with null
versions when proposing SafeMigration transactions.

## Changes

- Add `getSafeMigrationDeployments()` helper function in deployments.ts
- Update `detectDelegateMigration()` to check both SafeToL2Migration and
  SafeMigration contracts
- Implement version inference for SafeMigration by checking available
  singletons on the target chain (since SafeMigration functions have no
  parameters and use immutable addresses set at deployment)

## Test Coverage

- Add encoder builder for SafeMigration functions (migrateL2Singleton,
  migrateL2WithFallbackHandler, migrateSingleton, migrateWithFallbackHandler)
- Add 8 comprehensive unit tests covering:
  - Success cases for all 4 SafeMigration functions
  - Rejection of unofficial migration contracts
  - Rejection of non-DELEGATE operations
  - Rejection of transactions without data
  - Version inference behavior when singletons are/aren't available

Fixes production issue where Safe Shield migration transactions were failing
with "422: Could not calculate safeTxHash" error.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* refactor: remove unsupported version 1.4.0 from SafeMigration detection

* refactor: remove SafeToL2Migration support, keep only SafeMigration

Simplifies the codebase by removing SafeToL2Migration detection logic
and focusing only on SafeMigration contract support, which is what's
needed for the production issue on opBNB/Binance chains.

## Changes

- Remove SafeToL2Migration ABI import and function decoding
- Remove getSafeToL2MigrationDeployments wrapper function
- Remove ... (continued)

Run Details

3854 of 4761 branches covered (80.95%)

Branch coverage included in aggregate %.

13 of 14 new or added lines in 2 files covered. (92.86%)

14 existing lines in 2 files now uncovered.

13012 of 13991 relevant lines covered (93.0%)

539.93 hits per line