comunica / comunica / 18530404730

100%

push

github

Fix outer GRAPH ?g being considered in MINUS variable disjointness

Since our algebraic graph translation is not really part of the spec,
there is a MINUS edge case we need to consider with GRAPH ?g.
If left and right of MINUS have disjoint variables,
the whole left solution sequence must be kept.
If GRAPH is defined outside of an operator (e.g. MINUS),
then the spec says that evaluation of the operators
must be done as union over the evaluation of that operator
within each graph separately,
and that the variable of ?g must only be bound
**after** that evaluation.
As such, MINUS will not be aware of this variable ?g,
and the disjoint case will apply.
This is fixed by adding metadata to the operation so that engines
can special-case this.

See https://github.com/w3c/rdf-tests/pull/228
https://github.com/joachimvh/SPARQLAlgebra.js/pull/128

5489 of 5489 branches covered (100.0%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 2 files covered. (100.0%)

10936 of 10936 relevant lines covered (100.0%)

9306.34 hits per line